[charts] Add "use client" directive to every public component and hook
#14578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: charts
flaviendelangle
changed the title
"use client" directive to every public component and hook
|
Deploy preview: https://deploy-preview-14578--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #14578 will not alter performanceComparing Summary
|
JCQuintas
approved these changes
Sep 11, 2024
| @@ -1,3 +1,4 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
I'm not sure here: mui/material-ui#41956 (comment).
Edit: no, we are good mui/material-ui#43778.
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 5, 2024
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #14562. Part of #9833.
@alexfauquette @JCQuintas I let you check if some components or hooks can work and be valuable in RSC 👍